cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11181) Browser platform requires a favicon.ico file
Date Mon, 26 Jun 2017 23:26:00 GMT

    [ https://issues.apache.org/jira/browse/CB-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063969#comment-16063969
] 

ASF GitHub Bot commented on CB-11181:
-------------------------------------

GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-browser/pull/35

    CB-11181 add default favicon

    
    ### Platforms affected
    Browser
    
    ### What does this PR do?
    adds default favicon, that 'should' be overwritten by apps targeting browser, this avoids
a 404 shown in console.error
    
    ### What testing has been done on this change?
    manual
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-browser CB-11181

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit db6d1180296b8578a596e6f03d5b4adc49e5fff6
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-06-26T23:22:50Z

    CB-11181 add default favicon

----


> Browser platform requires a favicon.ico file
> --------------------------------------------
>
>                 Key: CB-11181
>                 URL: https://issues.apache.org/jira/browse/CB-11181
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-browser
>    Affects Versions: 3.5.0
>         Environment: Chrome browser
>            Reporter: Robert Posener
>            Assignee: Jesse MacFadyen
>            Priority: Minor
>              Labels: triaged
>
> If a favicon.ico file is not presenet in the www folder, a 404 error is thrown in the
console.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message