cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8098) Media plugin change plackback rate
Date Wed, 07 Jun 2017 21:09:19 GMT

    [ https://issues.apache.org/jira/browse/CB-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041614#comment-16041614
] 

ASF GitHub Bot commented on CB-8098:
------------------------------------

Github user dellagustin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120745011
  
    --- Diff: src/android/AudioPlayer.java ---
    @@ -532,6 +532,27 @@ public void setVolume(float volume) {
             }
         }
     
    +     /**
    +     * Set the rate for audio player
    +     *
    +     * @param rate
    +     */
    +
    +    public void setRate(float rate) {
    +        if (this.player != null) {
    +              
    +            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
    --- End diff --
    
    I'm not sure if there is a guideline here, or what is the standard behavior in this cases,
but should whe not send an error stats or something when the version does not meet the minimum
requirement?


> Media plugin change plackback rate
> ----------------------------------
>
>                 Key: CB-8098
>                 URL: https://issues.apache.org/jira/browse/CB-8098
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: cordova-plugin-media
>    Affects Versions: 3.5.0
>            Reporter: Alex
>
> Doesn't Media plugin support chanding playback rate? I dind't find any mention in docs.
I think this fis must even flaw HTML5 audio has it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message