cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12787) cordova@7 plugin add --link is broken
Date Fri, 12 May 2017 11:51:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008006#comment-16008006
] 

ASF GitHub Bot commented on CB-12787:
-------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-lib/pull/557

    CB-12787: Fix plugin installation with --link option

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    all
    
    ### What does this PR do?
    Fix logic for installation plugins with `--link` option.
     - Use `npm link` instead of `npm install` during plugin fetch.
     - Find symbolic links in plugin's dir for plugin removal 
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-lib CB-12787

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #557
    
----
commit 0eb176af7f6b00984f3d41320a1ff6f7f494928c
Author: Nikita Matrosov <v-nimatr@microsoft.com>
Date:   2017-05-12T11:26:05Z

    CB-12787: Fix plugin installation with --link option

----


> cordova@7 plugin add --link is broken
> -------------------------------------
>
>                 Key: CB-12787
>                 URL: https://issues.apache.org/jira/browse/CB-12787
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-fetch, cordova-lib
>    Affects Versions: 7.0.0
>            Reporter: Steve Gill
>              Labels: cordova-8.0.0
>
> with the change to cordova-fetch for local paths, cordova plugin add SOMELOCALPATH --link
doesn't work anymore. 
> The plugin first gets `npm installed` into your cordova project (so it now lives in node_modules),
and then it gets copied into your plugins directory. During the copy to your plugins directory
step, that is when the symlink gets created. So the symlink points to your node_modules/PLUGINDIR
and not the local path to your plugin.
> I believe the solution to fixing this would be to `npm link` the plugin instead of `npm
install` when adding it with `--link` flag. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message