cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12757) Cordova@7 saves wrong spec in config.xml for git plugins
Date Thu, 04 May 2017 17:36:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997122#comment-15997122
] 

ASF GitHub Bot commented on CB-12757:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/552

    CB-12757 : Was previously saving wrong spec in config.xml for git plugins.

    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    Was previously saving wrong spec in config.xml for git plugins.
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib CB-12757

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #552
    
----
commit 349693249febd62a0828aaf27c07d98c22c45a6f
Author: Audrey So <audreyso@apache.org>
Date:   2017-05-04T17:08:47Z

    CB-12757 : if there's a plugin  dependency in pkgJson, use that one for config

----


> Cordova@7 saves wrong spec in config.xml for git plugins
> --------------------------------------------------------
>
>                 Key: CB-12757
>                 URL: https://issues.apache.org/jira/browse/CB-12757
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli, cordova-lib
>    Affects Versions: cordova7
>            Reporter: Darryl Pogue
>            Priority: Minor
>              Labels: cordova7, reproduced, triaged
>             Fix For: cordova7
>
>
> (This possibly existed in earlier versions, I never used on the {{--save}} flag so I'm
not sure...)
> {code}
> cordova plugin add cordova-plugin-ayogo-push@AyogoHealth/cordova-plugin-push
> {code}
> It saves the github repo properly into package.json, but in config.xml it sets the spec
to the version number. This will fail to restore (from config.xml) because the plugin isn't
published to the npm registry.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message