cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12745) Add suppport for data: URIs which are not Base64 encoded
Date Mon, 01 May 2017 10:22:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990711#comment-15990711
] 

ASF GitHub Bot commented on CB-12745:
-------------------------------------

GitHub user Viras- opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178

    CB-12745: (iOS) Adding support for non base64 encoded data-URIs

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adding support for non base64 encoded data-URIs
    
    ### What testing has been done on this change?
    Tested on iOS Simulator
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Viras-/cordova-plugin-file-transfer CB-12745

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit fa6be13549b4234fca163fa74f51bc259506243d
Author: Viras- <viras@users.sourceforge.net>
Date:   2017-05-01T10:20:35Z

    CB-12745: (iOS) Adding support for non base64 encoded data-URIs

----


> Add suppport for data: URIs which are not Base64 encoded
> --------------------------------------------------------
>
>                 Key: CB-12745
>                 URL: https://issues.apache.org/jira/browse/CB-12745
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS, Plugin File Transfer
>            Reporter: Wolfgang Koller
>            Assignee: Wolfgang Koller
>
> Currently the FileUpload implementation on iOS expects the data URI content to be Base64
encoded. In order to be more compatible to the Android implementation, it should be possible
to also use non Base64 encoded content.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message