cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12738) cordova ignores plugin dependency version
Date Wed, 10 May 2017 09:39:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004399#comment-16004399
] 

ASF GitHub Bot commented on CB-12738:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/554
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=h1) Report
    > Merging [#554](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-lib/commit/3962053f7f5c7c65259f9926a220671595c6d944?src=pr&el=desc)
will **decrease** coverage by `0.04%`.
    > The diff coverage is `62.5%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/554/graphs/tree.svg?width=650&src=pr&token=KwBjKMXLqA&height=150)](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #554      +/-   ##
    ==========================================
    - Coverage   79.48%   79.44%   -0.05%     
    ==========================================
      Files          57       57              
      Lines        3944     3950       +6     
      Branches      828      830       +2     
    ==========================================
    + Hits         3135     3138       +3     
    - Misses        809      812       +3
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [cordova-lib/src/plugman/fetch.js](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vZmV0Y2guanM=)
| `80.72% <62.5%> (-1.16%)` | :arrow_down: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=footer).
Last update [3962053...d0c2bef](https://codecov.io/gh/apache/cordova-lib/pull/554?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> cordova ignores plugin dependency version
> -----------------------------------------
>
>                 Key: CB-12738
>                 URL: https://issues.apache.org/jira/browse/CB-12738
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli, cordova-lib
>            Reporter: Marcus Pridham
>
> You can see this with the cordova-plugin-file-transfer.  When you install this plugin
and it installs the cordova-plugin-file plugin dependency the CLI writes
> Fetching plugin "cordova-plugin-file" via npm
> The first problem is in the PluginInfo _parseDependency function
> https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-common/src/PluginInfo/PluginInfo.js;h=48174707b0dbf6f60eb65faeb14c51e4b3868b1b;hb=HEAD#l108
> It does not parse out the dependency version.  This part:
> {code}
>         var dep =
>             { id : tag.attrib.id
>             , url : tag.attrib.url || ''
>             , subdir : tag.attrib.subdir || ''
>             , commit : tag.attrib.commit
>             };
> {code}
> Should be:
> {code}
>         var dep =
>             { id : tag.attrib.id
>             , url : tag.attrib.url || ''
>             , subdir : tag.attrib.subdir || ''
>             , commit : tag.attrib.commit
>             , version : tag.attrib.version
>             };
> {code}  
> The second problem is in the plugman installDependency method
> https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/plugman/install.js;h=fca77c688d2b8f19ce63cb176f50ecd44c9a9032;hb=HEAD#l603
> The dep_src is only constructed using the plugin id.
> This:
> {code}
> var dep_src = dep.url.length ? dep.url : dep.id;
> {code}
> Should look something like:
> {code}
>         var dep_src;
>         if (dep.url.length) {
>             dep_src = dep.url;
>         }
>         else if (dep.version) {
>             dep_src = dep.id + '@' + dep.version;
>         } else {
>             dep_src = dep.id;
>         } 
> {code}
> With these changes the Cordova CLI correctly reports:
> Fetching plugin "cordova-plugin-file@^4.0.0" via npm



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message