cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
Date Wed, 10 May 2017 11:18:04 GMT

    [ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004496#comment-16004496
] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-lib/pull/555

    Improve logic for searching plugin id in case of module already exists in node_modules

    
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    all
    
    ### What does this PR do?
    Steps to reproduce w/ `cordova-7.0.2-dev`
    There is the issue with searching plugin id if the module already exists in node_modules.
    1. `cordova create sample`
    2. `cordova platform add android`
    3. `cordova plugin add cordova-plugin-ms-adal`
    4. `cordova plugin add ../azure-activedirectory-library-for-cordova` (use local folder)
    
    Get error message:
    ```
    cordova plugin add ..\azure-activedirectory-library-for-cordova\
    Error: Failed to get absolute path to installed module
    ```
    This error occurs since folder name in `node_modules` (`cordova-plugin-ms-adal`) differs
from base name of installation folder (`azure-activedirectory-library-for-cordova`).
    
    I'll create a new issue if this change is really needed.
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-lib improve-trim-id

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #555
    
----
commit 32aa75fd68c5d13f0e6c973443bf053e648c99a6
Author: Nikita Matrosov <v-nimatr@microsoft.com>
Date:   2017-05-10T10:57:18Z

    Improve logic for searching plugin id in case of module already exists in node_modules

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-blackberry (DEPRECATED), cordova-cli
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating BlackBerry
project...
> Updating config.xml ...
> sed: /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message