Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C27C0200C7B for ; Sat, 15 Apr 2017 03:11:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C1482160B8C; Sat, 15 Apr 2017 01:11:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E599F160BAF for ; Sat, 15 Apr 2017 03:11:45 +0200 (CEST) Received: (qmail 39425 invoked by uid 500); 15 Apr 2017 01:11:45 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 39309 invoked by uid 99); 15 Apr 2017 01:11:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Apr 2017 01:11:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7C8ACC0254 for ; Sat, 15 Apr 2017 01:11:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PJYFYlmxP577 for ; Sat, 15 Apr 2017 01:11:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4F38761A49 for ; Sat, 15 Apr 2017 01:11:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AE713E0AB0 for ; Sat, 15 Apr 2017 01:11:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E79B121B5A for ; Sat, 15 Apr 2017 01:11:41 +0000 (UTC) Date: Sat, 15 Apr 2017 01:11:41 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12517) config.xml name value and id values should be copied into pkgjson MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 15 Apr 2017 01:11:46 -0000 [ https://issues.apache.org/jira/browse/CB-12517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969758#comment-15969758 ] ASF subversion and git services commented on CB-12517: ------------------------------------------------------ Commit 08d47d86e55b5e471d1a8eac709d2191eecb09cb in cordova-lib's branch refs/heads/common-2.0.x from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=08d47d8 ] CB-12425 & CB-12517 :12425: autocreate a package.json if it doesn't exist during restore & 12517: pkgJson name is config id and pkgJson displayname is config's name CB-12517 : pkgJson's name is config.xml's id and pkgjson's displayName is config.xml's name This closes #521 > config.xml name value and id values should be copied into pkgjson > ----------------------------------------------------------------- > > Key: CB-12517 > URL: https://issues.apache.org/jira/browse/CB-12517 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-create > Reporter: Steve Gill > Assignee: Audrey So > Labels: cordova-7.0.0 > > cordova create currently takes config.xml name value and copies it over to package.json name value. It makes more sense to copy that over to a new value in package.json called displayName and copy config.xml's id field as package.json name. > The config.xml ID is lowercase and has no spaces where the config.xml name can have spaces which is invalid for package.json -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org