Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 20684200C72 for ; Thu, 27 Apr 2017 22:18:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1F136160B9E; Thu, 27 Apr 2017 20:18:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6B9C6160BA7 for ; Thu, 27 Apr 2017 22:18:09 +0200 (CEST) Received: (qmail 55843 invoked by uid 500); 27 Apr 2017 20:18:08 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 55827 invoked by uid 99); 27 Apr 2017 20:18:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 20:18:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0E44BC1F55 for ; Thu, 27 Apr 2017 20:18:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vQWuPwt3_io7 for ; Thu, 27 Apr 2017 20:18:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8D15E5FCEA for ; Thu, 27 Apr 2017 20:18:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B4CBCE0DA5 for ; Thu, 27 Apr 2017 20:18:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E556A21DF7 for ; Thu, 27 Apr 2017 20:18:04 +0000 (UTC) Date: Thu, 27 Apr 2017 20:18:04 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12497) location.href links are silently disallowed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 27 Apr 2017 20:18:10 -0000 [ https://issues.apache.org/jira/browse/CB-12497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987568#comment-15987568 ] ASF subversion and git services commented on CB-12497: ------------------------------------------------------ Commit 8755a699187c7fc2203c98fcc4fa78b89f1c513e in cordova-plugin-wkwebview-engine's branch refs/heads/1.1.x from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=8755a69 ] CB-12497 - location.href links are silently disallowed This closes #32 > location.href links are silently disallowed > ------------------------------------------- > > Key: CB-12497 > URL: https://issues.apache.org/jira/browse/CB-12497 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin WKWebViewEngine > Reporter: Shazron Abdullah > Assignee: Shazron Abdullah > > See: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20#issuecomment-281861506 > Ok, for location.href (say in a button tag onclick handler), it's definitely a bug when using wkwebview-engine (UIWebView is fine). For the CDVIntentAndNavigationFilter, we are passing back the navigationType, which is of type [WKNavigationType](https://developer.apple.com/reference/webkit/wknavigationtype). It looks like the enumeration is the same as [UIWebViewNavigationType](https://developer.apple.com/reference/uikit/uiwebviewnavigationtype) (which the filter uses for its logic), but not quite. > All enum integral values are the same for the two enumerations, except for [WKNavigationTypeOther](https://developer.apple.com/reference/webkit/wknavigationtype/1401930-other) which is set to -1 explicitly, while [UIWebViewNavigationTypeOther](https://developer.apple.com/reference/uikit/uiwebviewnavigationtype/1617934-other) is 5. > I'll file an issue to fix this by coercing the value explicitly to UIWebViewNavigationTypeOther when a WKNavigationTypeOther is encountered, before passing it off to the filter. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org