cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12695) jshint failure in vibrate plugin
Date Mon, 24 Apr 2017 23:59:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982141#comment-15982141
] 

ASF GitHub Bot commented on CB-12695:
-------------------------------------

GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-plugin-vibration/pull/53

    CB-12695: fix jshint / double-varing

    ### Platforms affected
    
    All - JS
    
    ### What does this PR do?
    
    Fixes `npm test` failure due to double-definition of `pattern` variable.
    
    ### What testing has been done on this change?
    
    Just `npm test`. Ideally should wait for the CI qa-bot to respond before merging.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database: [CB-12695](https://issues.apache.org/jira/browse/CB-12695)
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/cordova-plugin-vibration jshint-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-vibration/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 168204b2eb9e91eb8beb08b560cc87c048ab1a74
Author: filmaj <maj.fil@gmail.com>
Date:   2017-04-24T23:52:35Z

    CB-12695: fix jshint / double-varing

----


> jshint failure in vibrate plugin
> --------------------------------
>
>                 Key: CB-12695
>                 URL: https://issues.apache.org/jira/browse/CB-12695
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Vibration
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>              Labels: pluginsrelease
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message