cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergii Stotskyi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12682) Consistent cancel message between iOS and Android
Date Fri, 21 Apr 2017 12:21:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978612#comment-15978612
] 

Sergii Stotskyi commented on CB-12682:
--------------------------------------

it'd even better to provide different error classes for different situations. Like {{Camera.CancelError}}
for canceling, {{Camera.Error}} for unrecoverable error, {{Camera.AccessError}} for permissions
issue, {{Camera.NotSupportedError}} for cases when device doesn't have camera at all. But
I think it will be a matter of a separate improvement.

But I'd like to understand whether you guys think it worth to change this. I my opinion it
worth as it will allow to detect errors based on types, not based on strings (which I think
is fragile)

> Consistent cancel message between iOS and Android
> -------------------------------------------------
>
>                 Key: CB-12682
>                 URL: https://issues.apache.org/jira/browse/CB-12682
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>    Affects Versions: 2.4.0
>            Reporter: Sergii Stotskyi
>              Labels: ios
>
> Currently when user taps on "Cancel" button in camera modal plugin, returns inconsistent
error message.
> For iOS it returns: no image selected
> For Android: Camera cancelled
> I'd like it to be consistent as it will simplify check of whether it's cancel error or
other errors.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message