cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12626) Splashscreen crashing on Samsung devices, not rendering on others
Date Sun, 02 Apr 2017 14:29:42 GMT

    [ https://issues.apache.org/jira/browse/CB-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952702#comment-15952702
] 

ASF GitHub Bot commented on CB-12626:
-------------------------------------

GitHub user Lazza opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/125

    CB-12626: (android) Fix crash on Samsung devices and splash screen not showing on some
other devices

    ### Platforms affected
    
    Android, all versions.
    
    ### What does this PR do?
    
    This PR drops the strategy of relying on the app preferences to store the `drawableId`
for the splash screen. This approach causes crashes on Samsung devices and prevents the splash
screen from working correctly on some other devices.
    
    ### What testing has been done on this change?
    
    This change has been tested on all devices reported in the JIRA issue:
    
    - Samsung Galaxy 7 Edge, Android 7.0
    - Samsung Galaxy Note 4, Android 6.0.1
    - Lenovo/Zuk Z1, Android 5.1.1
    - Official Android Emulator with Nexus S simulated hardware, API 25
    
    ### Checklist
    
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Lazza/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit f94a2c27e5c1082c8b73949e3bf18d0ec4609f9e
Author: Andrea Lazzarotto <andrea.lazzarotto@gmail.com>
Date:   2017-03-15T12:03:00Z

    Samsung crash quick-n-dirty fix

commit f6aab146a45e172151fe931436534ba143238ec5
Author: Andrea Lazzarotto <andrea.lazzarotto@gmail.com>
Date:   2017-04-01T13:22:23Z

    Updated Android plugin
    
    Prefer a slightly slower, but bulletproof, way to check for the splashscreen instead of
relying on the Cordova preferences. This fixes the splash screen on several phones.

----


> Splashscreen crashing on Samsung devices, not rendering on others
> -----------------------------------------------------------------
>
>                 Key: CB-12626
>                 URL: https://issues.apache.org/jira/browse/CB-12626
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin SplashScreen
>         Environment: Crashing devices:
> - Samsung Galaxy 7 Edge, Android 7.0
> - Samsung Galaxy Note 4, Android 6.0.1
> "Not showing" devices:
> - Lenovo/Zuk Z1, Android 5.1.1
> - Official Android Emulator with Nexus S simulated hardware, API 25
>            Reporter: Andrea Lazzarotto
>              Labels: android
>
> We tested the plugin on a few Samsung devices and found out that the current version
of the splash screen plug-in is completely crashing the app, with an error given by {{AndroidRuntime}}
(including the PID of the app) and a warning given by {{ActivityManager}} in the log:
> {{Force finishing activity packagename/.MainActivity}}
> Moreover, we noticed that the splash screen is not showing correctly on some devices.
The Samsung crash was initially solved by commenting out this line:
> {{preferences.set("SplashDrawableId", drawableId);}}
> Basically, this means that storing the {{drawableId}} in the preferences is not reliable.
This didn't solve the display issue on other devices, which required refactoring the code
that reads the resource ID.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message