cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12266) InappBrowser: Browser: loadstop event.url is not a string
Date Thu, 13 Apr 2017 12:49:41 GMT


ASF GitHub Bot commented on CB-12266:

GitHub user matrosov-nikita opened a pull request:

    CB-12266 browser: Fix type for InAppBrowserEvent url in docs

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    fix doc's description for URL
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull fix-docs

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #217
commit 6a93e34d459cd13ce74c9b01b595e242399ece16
Author: Nikita Matrosov <>
Date:   2017-04-06T10:33:30Z

    CB-12266 browser: Fix type for InAppBrowserEvent url in docs


> InappBrowser: Browser: loadstop event.url is not a string
> ---------------------------------------------------------
>                 Key: CB-12266
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Browser, Plugin InAppBrowser
>    Affects Versions: 3.5.0
>         Environment: All browsers (Chrome, Firefox and IE tested)
>            Reporter: Pieter-Jan Dewitte
>            Priority: Minor
> In the browser, the url attribute of the loadstop event (InAppBrowserEvent) is not a
string as documented, but a Location object. The url is stored in event.href.
> Steps to reproduce:
> {quote}
> $ cordova create eventstop_url
> $ cd eventstop_url
> $ cordova plugin add cordova-plugin-inappbrowser
> {quote}
> Run the following code after device ready:
> {code:javascript}
> // as an example because it is allowed by the default CSP
> var ref ='', '_blank');
> ref.addEventListener('loadstop', function (event) {
>     console.log("loadstop event:", event);
> });
> {code}
> {quote}
> $ cordova serve
> {quote}
> The console output is:
> {quote}
> loadstop event: Object \{type: "loadstop", url: Location\}
> {quote}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message