cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
Date Fri, 21 Apr 2017 00:56:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977888#comment-15977888
] 

ASF GitHub Bot commented on CB-12015:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-android/pull/376
  
    # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr&el=h1) Report
    > Merging [#376](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-android/commit/e13e15d3e9aa4b9a61c6ece434e7c023fa5c3553?src=pr&el=desc)
will **not change** coverage.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/376/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr&el=tree)
    
    ```diff
    @@           Coverage Diff           @@
    ##           master     #376   +/-   ##
    =======================================
      Coverage   42.07%   42.07%           
    =======================================
      Files          14       14           
      Lines        1338     1338           
      Branches      245      245           
    =======================================
      Hits          563      563           
      Misses        775      775
    ```
    
    
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr&el=footer).
Last update [e13e15d...c06b96c](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> initial-scale values less than 1.0 are ignored on Android
> ---------------------------------------------------------
>
>                 Key: CB-12015
>                 URL: https://issues.apache.org/jira/browse/CB-12015
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: cordova-android@5.2.2
>            Reporter: Simon MacDonald
>
> So, the way cordova-android is right now if I use:
>     <meta name="viewport" content="user-scalable=no, initial-scale=1.0" />
> Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes everything bigger.
However, setting:
>     <meta name="viewport" content="user-scalable=no, initial-scale=0.5" />
> has no effect whatsoever.
> Going into the SystemWebViewEngine class and adding:
>     settings.setUseWideViewPort(true);
>     settings.setLoadWithOverviewMode(true);
> to initWebViewSettings() method then allows me to scale the viewport down. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message