cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12009) <resource-file> target attribute ignored on iOS when installing a Cordova plugin
Date Fri, 21 Apr 2017 00:15:04 GMT

    [ https://issues.apache.org/jira/browse/CB-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977842#comment-15977842
] 

ASF subversion and git services commented on CB-12009:
------------------------------------------------------

Commit 4100816464cca3c4dd4fea394e84c349b973a908 in cordova-ios's branch refs/heads/master
from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=4100816 ]

CB-8980 - fix <resource-file> target attribute in config.xml

The target attribute was not working properly - reflecting how the <resource-file> target
attribute works in plugin.xml (related CB-12009)

 This closes #308


> <resource-file> target attribute ignored on iOS when installing a Cordova plugin
> --------------------------------------------------------------------------------
>
>                 Key: CB-12009
>                 URL: https://issues.apache.org/jira/browse/CB-12009
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 6.3.0, 6.3.1
>            Reporter: Mark Veenstra
>            Priority: Critical
>             Fix For: cordova-ios@4.4.1
>
>
> In the Cordova plugin.xml documentation it is stated that the {{<resource-file>}}
tag can have an attribute {{target}}. See next link: https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#resource-file
> But when I try to use this target attribute it is just ignored and all {{<resource-file>}}
configurations are added to the {{Resources}} directory on iOS.
> It seems to me that the {{cordova-lib}} code just ignores this {{target}} attribute,
see next link: https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L165
> The code grabbed from that link:
> {{destFile = path.resolve(project.resources_dir, path.basename(src));}}
> Here you can see the destFile is hardcoded for the resources_dir.
> We are trying to add push notification sounds to the iOS {{Resources}} directory as well
as adding it to either the bundle root or {{Library/Sounds}}. Because we have seen that since
iOS 10 we need to put the sounds files elsewhere then the {{Resources}} directory to get it
work. See: https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/TheNotificationPayload.html#//apple_ref/doc/uid/TP40008194-CH107-SW1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message