cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8978) Adding <resource-file> tag support to config.xml
Date Fri, 21 Apr 2017 07:18:04 GMT

    [ https://issues.apache.org/jira/browse/CB-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978207#comment-15978207
] 

ASF GitHub Bot commented on CB-8978:
------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/547
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr&el=h1) Report
    > Merging [#547](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-lib/commit/8030d2af347008610bb05d55c1499db9d8195f83?src=pr&el=desc)
will **not change** coverage.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/547/graphs/tree.svg?height=150&width=650&token=KwBjKMXLqA&src=pr)](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr&el=tree)
    
    ```diff
    @@           Coverage Diff           @@
    ##           master     #547   +/-   ##
    =======================================
      Coverage   83.34%   83.34%           
    =======================================
      Files          65       65           
      Lines        5163     5163           
      Branches     1029     1029           
    =======================================
      Hits         4303     4303           
      Misses        860      860
    ```
    
    
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr&el=footer).
Last update [8030d2a...8a4dde1](https://codecov.io/gh/apache/cordova-lib/pull/547?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> Adding <resource-file> tag support to config.xml
> ------------------------------------------------
>
>                 Key: CB-8978
>                 URL: https://issues.apache.org/jira/browse/CB-8978
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: CLI, CordovaLib
>    Affects Versions: Master
>         Environment: Android, iOS, WP8, Windows, Blackberry
>            Reporter: Karen Tran
>            Assignee: Karen Tran
>              Labels: config.xml, images
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> At present, there are only an icon element and splashscreen element that handles copying
images from a source to destination in the config.xml. These elements also only handle copying
1 image only and replacing what was previously there as the icon.png or splash.png. 
> I'm creating a new tag that will copy non-main app icon images, which could be notification
icons, button icons, custom image text, etc. and not limited to just 1 image. 
> Example:
> <image src="res/android/notification.png" name="notification.png" />
> <image src="res/android/notification-mdpi.png" name="notification.png" density="mdpi"
/>
> The required attributes will be src and name. 
> Depending on the directory that the image gets copied to, the width and height attribute
may not be needed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message