cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bowser (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-2627) HTML File Input should support accept/source attributes
Date Sat, 08 Apr 2017 13:28:41 GMT

    [ https://issues.apache.org/jira/browse/CB-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961835#comment-15961835
] 

Joe Bowser edited comment on CB-2627 at 4/8/17 1:27 PM:
--------------------------------------------------------

[~awebdeveloper] This does not at all decrease the overhead of maintaining camera, it just
makes the file picker way more complicated by adding five more intents and moving that complexity
into the core platform. In short, this will make upgrading Cordova worse for everyone who
doesn't use Camera and this will add additional instability w.r.t. Intents being passed to
plugins.  Secondly, iOS is a completely different platform which doesn't have intents, so
you would have to ask [~shazron] about exactly why it has it implemented or if he added anything.
 That being said, I suspect that iOS has more features more tightly coupled to UiWebView and
WkWebView.

This issue is low priority because it's an extremely complicated issue to implement and test,
and we already have plugins like Camera that work better than this method.  Beyond responding
to issues when someone is actively working on them and evaluating any PRs that come in, I'm
not going to work on this. The only way this feature is going to be implemented is if the
community actually does it, which is what [~NiklasMerz] is doing.  That being said, this feature
would have to have a ton of tests, since it would likely be the most fragile part of the whole
framework due to the fact that we now have to manage all the file picker intents on top of
the all the intents that the plugins can call.

[~NiklasMerz] If you are going to keep going down this route, I would recommend ignoring InAppBrowser
for the moment, since you'd have to route all the intent handlers through the Plugin API.


was (Author: bowserj):
[~awebdeveloper] This does not at all decrease the overhead of maintaining camera, it just
makes the file picker way more complicated by adding five more intents and moving that complexity
into the core platform. In short, this will make upgrading Cordova worse for everyone who
doesn't use Camera and this will add additional instability w.r.t. Intents being passed to
plugins.  Secondly, iOS is a completely different platform which doesn't have intents, so
you would have to ask [~shazron] about exactly why it has it implemented or if he added anything.
 That being said, I suspect that iOS has more features more tightly coupled to UiWebView and
WkWebView.

This issue is low priority because it's an extremely complicated issue to implement and test,
and we already have plugins like Camera that work better than this method.  Beyond responding
to issues when someone is actively working on them and evaluating any PRs that come in, I'm
not going to work on this. The only way this feature is going to be implemented is if the
community actually does it, which is what [~NiklasMerz] is doing.  That being said, this feature
would have to have a ton of tests, since it would likely be the most fragile part of the whole
framework due to the fact that we now have to manage all the file picker intents on top of
the all the intents that the plugins can call.

[~NiklasMerz] If you are going to keep going down this route, I would recommend ignoring InAppBrowser
for the moment, since we'd have to route all the intent handlers through the Plugin API.

> HTML File Input should support accept/source attributes
> -------------------------------------------------------
>
>                 Key: CB-2627
>                 URL: https://issues.apache.org/jira/browse/CB-2627
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Michael Migdol
>            Priority: Minor
>
> [CB-2086] always opens a generic File Picker, regardless of the values passed in for
the mimetypes in the accept attribute, or the source attribute.  The Android Browser correctly
examines these attributes and starts up an activity with either: a camera intent, a camera/image
intent, a camcorder intent, a sound recorder intent, or a sound recorder/audio intent.  
> I'm not sure what cross-pollination is allowed between the Android codebase and Cordova's,
but it appears that packages/apps/Browser/src/com/android/browser/UploadHandler.java from
the Android source tree contains exactly what we need to accomplish the same.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message