Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 20 Mar 2017 16:32:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13056037.1489517760000.67133.1490027562139@Atlassian.JIRA>
In-Reply-To: <JIRA.13056037.1489517760000@Atlassian.JIRA>
References: <JIRA.13056037.1489517760000@Atlassian.JIRA> <JIRA.13056037.1489517760064@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12570) make --fetch true by default, make
 --nofetch flag
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 20 Mar 2017 16:32:49 -0000


    [ https://issues.apache.org/jira/browse/CB-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932986#comment-15932986 ] 

ASF GitHub Bot commented on CB-12570:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/271#discussion_r106771856
  
    --- Diff: doc/platform.txt ---
    @@ -11,29 +11,24 @@ Manage project platforms
                                             library directly instead of making a copy of it (support
                                             varies by platform; useful for platform development)
             
    -        --fetch ....................... Fetches the plugin into the project's node_modules directory. 
    -                                        Uses `npm install` to do the fetching.
    -
    -
    -
    +        --nofetch ..................... Prevent fetching the plugin into the project's node_modules 
    +                                        directory. Prevent using `npm install` to do the fetching.
     
         remove <platform> [...] ........... Remove specified platforms
             --save ........................ Delete specified platforms from config.xml after removing them
    -        --fetch ....................... Removes the plugin from the project's node_modules directory.
    -                                        Runs `npm uninstall` under the hood.
    -
    +        --nofetch ..................... Prevent removing the plugin from the project's node_modules 
    +                                        directory. Prevent running `npm uninstall` under the hood.
     
         update <plat-spec> ................ Update the version of Cordova used for a specific platform;
                                             update to the latest <version> if no <plat-spec> is specified
     
             --save ........................ Save the latest versions for specified platforms into config.xml
     
    -        --fetch ....................... Fetches the plugin into the project's node_modules directory. 
    -                                        Uses `npm install` to do the fetching.
    -
         list .............................. List all installed and available platforms
         check ............................. List platforms which can be updated by `cordova-cli platform update`
         save .............................. Save version of all platforms added to config.xml
    +    nofetch ........................... Prevents fetching the plugin into the project's node_modules 
    --- End diff --
    
    cordova platform nofetch isn't a command. i'd remove this line


> make --fetch true by default, make --nofetch flag
> -------------------------------------------------
>
>                 Key: CB-12570
>                 URL: https://issues.apache.org/jira/browse/CB-12570
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> We want to make --fetch true by default so all platform/plugin add/rm uses cordova-fetch under the hood.
> Similar to how autosave was handled in https://github.com/apache/cordova-cli/pull/266


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org