Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 7 Mar 2017 08:15:33 +0000 (UTC)
From: "Zia Sergio (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13047618.1488445965000.17073.1488874533022@Atlassian.JIRA>
In-Reply-To: <JIRA.13047618.1488445965000@Atlassian.JIRA>
References: <JIRA.13047618.1488445965000@Atlassian.JIRA> <JIRA.13047618.1488445965353@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12529) Support default 'cellular' detection
 into cordova-plugin-network-information for Android
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Mar 2017 08:15:37 -0000


    [ https://issues.apache.org/jira/browse/CB-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898925#comment-15898925 ] 

Zia Sergio commented on CB-12529:
---------------------------------

Hi Joe,
Ok, but in this case why the IOS version of this plugin can return "cellular" instead of "unknown" when the cellular type connection can not be detected for older IOS releases ?
OnePlus 3 device (Android 7.1) connected to the cellular data network of "Orange" or "Base" belgian providers returns a technology unsupported by the plugin when 4G is available for this connection.
Unfortunately I have not in my possession this device to debug what is the returned string in this case.
But I have built a release of my cordova application with the purposed patch implemented for test and it works.
In my opinion, when some application features need to be enabled/disabled in case of cellular connection, it is more useful to know it is a cellular connection instead of an unknown connection, even if the cellular technology can not be detected because perhaps too recent and not yet supported by your plugin.


> Support default 'cellular' detection into cordova-plugin-network-information for Android
> ----------------------------------------------------------------------------------------
>
>                 Key: CB-12529
>                 URL: https://issues.apache.org/jira/browse/CB-12529
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Network Information
>            Reporter: Zia Sergio
>            Priority: Minor
>              Labels: Android
>
> cordova-plugin-network-information/src/android/NetworkManager java class :
> Method getType() : In case of unknown cellular network detected, returned value is TYPE_UNKNOWN  (equals "unknown" string)
> It seems it is better in this case that returns "cellular" string.
> For this simply add a constant :
>     public static final String TYPE_CELL = "cellular";
> And add a 'else' statement after all 'else if' statements detecting the cellular connection sub-types :
>                 else {
>                     return TYPE_CELL;
>                 }


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org