Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 9 Mar 2017 18:42:38 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13047464.1488403287000.25044.1489084958433@Atlassian.JIRA>
In-Reply-To: <JIRA.13047464.1488403287000@Atlassian.JIRA>
References: <JIRA.13047464.1488403287000@Atlassian.JIRA> <JIRA.13047464.1488403287420@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12524) add plugin failing because it cannot
 find tools/templates
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 09 Mar 2017 18:42:45 -0000


    [ https://issues.apache.org/jira/browse/CB-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903588#comment-15903588 ] 

ASF GitHub Bot commented on CB-12524:
-------------------------------------

GitHub user infil00p opened a pull request:

    https://github.com/apache/cordova-android/pull/367

    CB-12524: Working around Android SDK update by finding Gradle in Android Studio itself, if that fails, we look for a locally installed Gradle

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This PR allows Cordova users to be able to build Android projects again using the platform CLI tools.  
    
    ### What testing has been done on this change?
    Testing has been done on the build scripts to make sure things work, but testing on the CLI integration still needs to be done.
    
    ### Checklist
    - [ x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/infil00p/cordova-android android_sdk_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #367
    
----
commit 78c5a54e5f255aab205ecbc72047b5cce9f18a66
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-06T23:03:32Z

    We're distributing a wrapper in the framework directory

commit 9469d11669fcf6ef4342954d46722144c9f36731
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-06T23:55:22Z

    CB-12524: Updating gradle to just grab the wrapper from the framework directory for building

commit 4502e3253783425eda5cff881e48f4d58de88e3e
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-07T22:29:02Z

    CB-12524: Create script needs to copy the wrapper from the framework directory to the CordovaLib directory.  This means you can compile an AAR out of any of the projects if you wanted.

commit 8c01438e16ad1403e9eb54d1870bbc8371458343
Author: Joe Bowser <bowserj@apache.org>
Date:   2017-03-09T02:09:49Z

    CB-12524: This now fetches the template from  inside of the Android Studio directory, and falls back to a locally installed Gradle instance

commit a4fa4b79fc6a8ad8afe9249aa591c62e1742d666
Author: Bharath Hariharan <bhariharan@salesforce.com>
Date:   2017-02-23T19:13:10Z

    Updating version
    
     This closes #364

commit f3408169735e01817bdde113547ca40375529ebb
Author: Joe Bowser <bowserj@gmail.com>
Date:   2017-03-09T18:26:48Z

    CB-12524: Windows functionality for Gradle execution

commit 45e3c6983470d47628e8deba23ab41498638a8a9
Author: Joe Bowser <bowserj@gmail.com>
Date:   2017-03-09T18:32:07Z

    Accidentally committed temp files in Windows

----


> add plugin failing because it cannot find tools/templates
> ---------------------------------------------------------
>
>                 Key: CB-12524
>                 URL: https://issues.apache.org/jira/browse/CB-12524
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, App Hello World
>    Affects Versions: 6.5.0
>         Environment: Mac OSX 10.12.3
> Cordova 6.5.0
> Android 6.1.2
>            Reporter: Gary N Griswold
>            Assignee: Joe Bowser
>            Priority: Blocker
>
> plugin add is failing because it is looking for in sdk/tools/templates/gradle/wrapper, but tools/templates does not exist.
> The reference to the missing templates directory is found in {quote}check_reqs.js line 88{quote}
> {code}
> platforms/android/cordova/lib/check_reqs.js
> line 88: var wrapperDir = path.join(sdkDir, 'tools', 'templates', 'gradle', 'wrapper');
> Please see the
> cordova plugin add $HOME/<local file spec>
> Failed to install 'com-shortsands-videoplayer':CordovaError: Could not find gradle wrapper within Android SDK. Might need to update your Android SDK.
> Looked here: /Users/garygriswold/Library/Android/sdk/tools/templates/gradle/wrapper
>     at Object.module.exports.check_gradle (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/check_reqs.js:90:25)
>     at GradleBuilder.prepEnv (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/builders/GradleBuilder.js:161:23)
>     at Api.module.exports.runClean (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/lib/build.js:131:20)
>     at /Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/Api.js:394:50
>     at _fulfilled (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:834:54)
>     at self.promiseDispatch.done (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:863:30)
>     at Promise.promise.promiseDispatch (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:796:13)
>     at /Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:604:44
>     at runSingle (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:137:13)
>     at flush (/Users/garygriswold/ShortSands/VideoProto/platforms/android/cordova/node_modules/q/q.js:125:13)
> Error: Could not find gradle wrapper within Android SDK. Might need to update your Android SDK.
> Looked here: /Users/garygriswold/Library/Android/sdk/tools/templates/gradle/wrapper
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org