Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 31 Mar 2017 17:34:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12966306.1462823088000.178246.1490981681735@Atlassian.JIRA>
In-Reply-To: <JIRA.12966306.1462823088000@Atlassian.JIRA>
References: <JIRA.12966306.1462823088000@Atlassian.JIRA> <JIRA.12966306.1462823088881@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-11233) Support installing frameworks into
 "Embedded Binaries" section of the Xcode project
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 31 Mar 2017 17:34:47 -0000


    [ https://issues.apache.org/jira/browse/CB-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951358#comment-15951358 ] 

ASF GitHub Bot commented on CB-11233:
-------------------------------------

Github user shazron commented on the issue:

    https://github.com/apache/cordova-lib/pull/534
  
    Looks like the AppVeyor failure is node 6 only, which is suspicious and probably a hiccup:
    ```
    1) HooksRunner fire method plugin hooks Test 011 : should filter hook scripts from plugin.xml by platform
      Message:
        Expected Error: Hook failed with error code 1: C:\Users\appveyor\AppData\Local\Temp\1\e2e-test\hooks_test\project\hooks\before_build\hookScript02.bat to be undefined.
      Stack:
        Error: Expected Error: Hook failed with error code 1: C:\Users\appveyor\AppData\Local\Temp\1\e2e-test\hooks_test\project\hooks\before_build\hookScript02.bat to be undefined.
            at C:\projects\cordova-lib\cordova-lib\spec-cordova\HooksRunner.spec.js:406:33
            at _rejected (C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:797:24)
            at C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:823:30
            at Promise.when (C:\projects\cordova-lib\cordova-lib\node_modules\q\q.js:1035:31)
    ```
    
    Thanks to @stevengill for the review. Seems any changes to `cordova-lib/src/plugman/platforms/ios.js` should be removed since in cordova@7 everything will be in the Platform API. I will close this PR and send a new (trivial) one for the `cordova-common` changes.


> Support installing frameworks into "Embedded Binaries" section of the Xcode project
> -----------------------------------------------------------------------------------
>
>                 Key: CB-11233
>                 URL: https://issues.apache.org/jira/browse/CB-11233
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: cordova-7.0.0
>             Fix For: cordova-ios@4.4.0
>
>
> Right now, this:
> {code}
> <framework src="Foo.framework" custom="true" />
> {code}
> .. links the framework statically into the program.
> There needs to be a similar directive that will install the framework into the "Embedded Binaries" section of the Xcode project. Frameworks that are installed in the "Embedded Binaries" section are dynamically loaded when needed by your iOS program.
> Two ways this can be done:
> 1. Overload the "custom" attribute (icky but we won't have to introduce a new attribute) to be a string, and the new value would be "dynamic"
> 2. Have a new "dynamic" attribute (boolean)


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org