cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12570) make --fetch true by default, make --nofetch flag
Date Mon, 20 Mar 2017 16:32:42 GMT

    [ https://issues.apache.org/jira/browse/CB-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932985#comment-15932985
] 

ASF GitHub Bot commented on CB-12570:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/271#discussion_r106772045
  
    --- Diff: src/cli.js ---
    @@ -390,16 +395,23 @@ function cli(inputArgs) {
                 });
             }
     
    +        if (args.nofetch) {
    --- End diff --
    
    Is this second `if (args.nofetch)` needed since you did it during line 306?


> make --fetch true by default, make --nofetch flag
> -------------------------------------------------
>
>                 Key: CB-12570
>                 URL: https://issues.apache.org/jira/browse/CB-12570
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> We want to make --fetch true by default so all platform/plugin add/rm uses cordova-fetch
under the hood.
> Similar to how autosave was handled in https://github.com/apache/cordova-cli/pull/266



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message