cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zia Sergio (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12529) Support default 'cellular' detection into cordova-plugin-network-information for Android
Date Fri, 03 Mar 2017 09:36:45 GMT

    [ https://issues.apache.org/jira/browse/CB-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893995#comment-15893995
] 

Zia Sergio commented on CB-12529:
---------------------------------

Simply because in this case, we know at least that there is a connection and that it is not
an ethernet connection nor a wi-fi connection.
It is not fully "unknown", we know in this case that it is a "cellular" connection and if
some features of our app can be executed only in case of "cellular" connection, it is so possible,
even the subtype of this connection is unknown.
Why do without this information ?

Also, to be coherent with the IOS plugin version that return "cellular" in this case !


> Support default 'cellular' detection into cordova-plugin-network-information for Android
> ----------------------------------------------------------------------------------------
>
>                 Key: CB-12529
>                 URL: https://issues.apache.org/jira/browse/CB-12529
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Zia Sergio
>
> cordova-plugin-network-information/src/android/NetworkManager java class :
> Method getType() : In case of unknown cellular network detected, returned value is TYPE_UNKNOWN
 (equals "unknown" string)
> It seems it is better in this case that returns "cellular" string.
> For this simply add a constant :
>     public static final String TYPE_CELL = "cellular";
> And add a 'else' statement after all 'else if' statements detecting the cellular connection
sub-types :
>                 else {
>                     return TYPE_CELL;
>                 }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message