cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12528) Remove silly existSync replacement
Date Sat, 04 Mar 2017 05:57:45 GMT

    [ https://issues.apache.org/jira/browse/CB-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895529#comment-15895529
] 

ASF GitHub Bot commented on CB-12528:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/524
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=h1) Report
    > Merging [#524](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr&el=desc)
will **decrease** coverage by `-0.02%`.
    > The diff coverage is `100%`.
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #524      +/-   ##
    ==========================================
    - Coverage    81.9%   81.88%   -0.02%     
    ==========================================
      Files          68       68              
      Lines        5504     5498       -6     
      Branches     1090     1090              
    ==========================================
    - Hits         4508     4502       -6     
      Misses        996      996
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [cordova-lib/src/util/npm-helper.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3V0aWwvbnBtLWhlbHBlci5qcw==)
| `95.65% <100%> (ø)` | :white_check_mark: |
    | [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
| `97.2% <100%> (-0.08%)` | :x: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=footer).
Last update [b0402b9...62d491f](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=footer&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Remove silly existSync replacement
> ----------------------------------
>
>                 Key: CB-12528
>                 URL: https://issues.apache.org/jira/browse/CB-12528
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaCommon
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>
> Remove bunk claim that existsSync is deprecated, so our own implementation is provided...
> It is not deprecated, our implementation appears to be unused.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message