cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12528) Remove silly existSync replacement
Date Fri, 03 Mar 2017 02:48:45 GMT


ASF GitHub Bot commented on CB-12528:

GitHub user purplecabbage opened a pull request:

    CB-12528 use fs instead of our own existsSync

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Removes unneeded API
    ### What testing has been done on this change?
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-12528

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #524
commit 62d491f3ff107ab03957ded15603667bf68e692f
Author: Jesse MacFadyen <>
Date:   2017-03-03T02:08:52Z

    use fs instead of our own existsSync


> Remove silly existSync replacement
> ----------------------------------
>                 Key: CB-12528
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaCommon
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
> Remove bunk claim that existsSync is deprecated, so our own implementation is provided...
> It is not deprecated, our implementation appears to be unused.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message