cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12384) Add Cordova framework target to iOS
Date Thu, 02 Mar 2017 22:40:46 GMT

    [ https://issues.apache.org/jira/browse/CB-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893173#comment-15893173
] 

ASF GitHub Bot commented on CB-12384:
-------------------------------------

Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/289#discussion_r104047971
  
    --- Diff: tests/CordovaLibTests/CordovaLibTests.xcodeproj/project.pbxproj ---
    @@ -39,8 +63,29 @@
     			remoteGlobalIDString = 303A4067152124BB00182201;
     			remoteInfo = CordovaLibApp;
     		};
    +		C0FA7CCC1E4BBD870077B045 /* PBXContainerItemProxy */ = {
    +			isa = PBXContainerItemProxy;
    +			containerPortal = 0867D690FE84028FC02AAC07 /* Project object */;
    +			proxyType = 1;
    +			remoteGlobalIDString = C0FA7C991E4BB6420077B045;
    +			remoteInfo = CordovaFrameworkApp;
    +		};
     /* End PBXContainerItemProxy section */
     
    +/* Begin PBXCopyFilesBuildPhase section */
    +		C0FA7CDE1E4BC5020077B045 /* Embed Frameworks */ = {
    +			isa = PBXCopyFilesBuildPhase;
    +			buildActionMask = 2147483647;
    +			dstPath = "";
    +			dstSubfolderSpec = 10;
    +			files = (
    +				C0FA7CDD1E4BC5020077B045 /* Cordova.framework in Embed Frameworks */,
    +			);
    +			name = "Embed Frameworks";
    +			runOnlyForDeploymentPostprocessing = 0;
    --- End diff --
    
    This value should be 1.
    This corresponds to the "Copy only when installing" checkbox in the Embed Frameworks section
for the Cordova framework target in the CordovaLib project.


> Add Cordova framework target to iOS
> -----------------------------------
>
>                 Key: CB-12384
>                 URL: https://issues.apache.org/jira/browse/CB-12384
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: CordovaLib, iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>            Assignee: Shazron Abdullah
>             Fix For: cordova-ios@4.4.0
>
>   Original Estimate: 40h
>  Remaining Estimate: 40h
>
> Carthage support requires a dynamic framework target for Cordova.  It should be possible
to create a framework target that lives side by side with the existing static library target
(CordovaLib), sharing code, tests, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message