cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12146) cordova-plugin-media - Adds support for "playAudioWhenScreenIsLocked" already used in iOS
Date Sat, 25 Mar 2017 01:41:41 GMT

    [ https://issues.apache.org/jira/browse/CB-12146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941482#comment-15941482
] 

ASF GitHub Bot commented on CB-12146:
-------------------------------------

GitHub user romedius opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/137

    CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android

    When loosing focus of the app in android (onPause()) the audio playback is paused when
playAudioWhenScreenIsLocked is set to false.
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Adds the playAudioWhenScreenIsLocked flag to the Android version. This makes it possible
to selectively keep audios playing, when onPause is called.
    
    ### What testing has been done on this change?
    Manual testing on Android N
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/romedius/cordova-plugin-media CB-12146cordova-plugin-media

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 36e4fdf22820f750d96774e0e254327aca062dec
Author: Romedius Weiss <romedius.weiss@gmail.com>
Date:   2017-03-24T17:54:26Z

    CB-12146 (android) Adding playAudioWhenScreenIsLocked for Android
    
    When loosing focus of the app in android (onPause()) the audio playback is paused if playAudioWhenScreenIsLocked
is set to false.

----


> cordova-plugin-media - Adds support for "playAudioWhenScreenIsLocked" already used in
iOS
> -----------------------------------------------------------------------------------------
>
>                 Key: CB-12146
>                 URL: https://issues.apache.org/jira/browse/CB-12146
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Media
>    Affects Versions: Master
>         Environment: Apache Cordova media plugin on Android
>            Reporter: Romedius Weiss
>            Priority: Minor
>              Labels: newbie, patch
>             Fix For: Master
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch adds the support of the playAudioWhenScreenIsLocked flag on Android, listed
as quirk for iOS.
> https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-media/#ios-quirks
> A previous version of the fix was published here:
> https://github.com/apache/cordova-plugin-media/pull/54



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message