cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11346) Remove known platforms check for Platform API
Date Thu, 16 Mar 2017 23:49:41 GMT

    [ https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929185#comment-15929185
] 

ASF GitHub Bot commented on CB-11346:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/529
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=h1) Report
    > Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc)
will **increase** coverage by `<.01%`.
    > The diff coverage is `92.68%`.
    
    
    ```diff
    @@            Coverage Diff            @@
    ##           master    #529      +/-   ##
    =========================================
    + Coverage    81.9%   81.9%   +<.01%     
    =========================================
      Files          68      68              
      Lines        5498    5499       +1     
      Branches     1090    1086       -4     
    =========================================
    + Hits         4503    4504       +1     
      Misses        995     995
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
| `93.75% <ø> (-0.44%)` | :x: |
    | [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
| `87.07% <ø> (-0.09%)` | :x: |
    | [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
| `97.2% <100%> (ø)` | :white_check_mark: |
    | [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
| `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
    | [cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
| `97.14% <94.73%> (+0.59%)` | :white_check_mark: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=footer).
Last update [07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer&src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Remove known platforms check for Platform API
> ---------------------------------------------
>
>                 Key: CB-11346
>                 URL: https://issues.apache.org/jira/browse/CB-11346
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>            Assignee: Jesse MacFadyen
>              Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message