cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11233) Support installing frameworks into "Embedded Binaries" section of the Xcode project
Date Thu, 30 Mar 2017 10:15:41 GMT

    [ https://issues.apache.org/jira/browse/CB-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948801#comment-15948801
] 

ASF GitHub Bot commented on CB-11233:
-------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/299

    CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode
project

    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate
installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for
the iOS platform
    
    ### What testing has been done on this change?
    
    Added unit tests.
    
    ### Other notes
    
    Complementary PR: https://github.com/apache/cordova-lib/pull/534
    I manually updated PluginInfo.js in the cordova-common bundledDependency for tests to
pass.
    
    ### Checklist
    
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-XXXX"
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-11233

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #299
    
----
commit 6edb7e6964f6fd90dba167deec7f77b7958510e2
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-03-30T10:12:25Z

    CB-11233 - Support installing frameworks into "Embedded Binaries" section of the Xcode
project

----


> Support installing frameworks into "Embedded Binaries" section of the Xcode project
> -----------------------------------------------------------------------------------
>
>                 Key: CB-11233
>                 URL: https://issues.apache.org/jira/browse/CB-11233
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>              Labels: cordova-7.0.0
>             Fix For: cordova-ios@4.4.0
>
>
> Right now, this:
> {code}
> <framework src="Foo.framework" custom="true" />
> {code}
> .. links the framework statically into the program.
> There needs to be a similar directive that will install the framework into the "Embedded
Binaries" section of the Xcode project. Frameworks that are installed in the "Embedded Binaries"
section are dynamically loaded when needed by your iOS program.
> Two ways this can be done:
> 1. Overload the "custom" attribute (icky but we won't have to introduce a new attribute)
to be a string, and the new value would be "dynamic"
> 2. Have a new "dynamic" attribute (boolean)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message