cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11062) Cloning git repo when installing a plugin doesn't fetch submodules
Date Fri, 24 Mar 2017 06:21:41 GMT

    [ https://issues.apache.org/jira/browse/CB-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939896#comment-15939896
] 

ASF GitHub Bot commented on CB-11062:
-------------------------------------

Github user stevengill commented on the issue:

    https://github.com/apache/cordova-lib/pull/424
  
    I think I'm going to close this. In cordova-7, we don't use gitclone.js and instead use
cordova-fetch which runs npm install under the hood. 


> Cloning git repo when installing a plugin doesn't fetch submodules
> ------------------------------------------------------------------
>
>                 Key: CB-11062
>                 URL: https://issues.apache.org/jira/browse/CB-11062
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib, Plugman
>    Affects Versions: 6.1.1
>            Reporter: Julian Frumar
>              Labels: triaged
>
> When installing a plugin using a git repo as the id, e.g:
> {code}cordova plugin install https://github.com/path_to_git_repo.git{code}
> The plugman helper [gitclone.js|https://github.com/apache/cordova-lib/blob/master/cordova-lib%2Fsrc%2Fgitclone.js]
doesn't retrieve using the *--recursive* option, so submodules are not fetched.
> This is breaking our plugin as cordova is failing to find all the necessary files as
specified in the plugin.xml (some of them are from a nested git submodule repo)
> Relevant PR: https://github.com/apache/cordova-lib/pull/424



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message