cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10438) Plugin dependency version/spec is not used/ignored
Date Tue, 14 Mar 2017 23:24:41 GMT

    [ https://issues.apache.org/jira/browse/CB-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925242#comment-15925242
] 

ASF GitHub Bot commented on CB-10438:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/527
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=h1) Report
    > Merging [#527](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr&el=desc)
will **increase** coverage by `0.02%`.
    > The diff coverage is `94.44%`.
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #527      +/-   ##
    ==========================================
    + Coverage    81.9%   81.92%   +0.02%     
    ==========================================
      Files          68       68              
      Lines        5498     5516      +18     
      Branches     1090     1099       +9     
    ==========================================
    + Hits         4503     4519      +16     
    - Misses        995      997       +2
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [cordova-lib/src/plugman/plugman.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...ed163b38a8d3235718d6abb254aa9060f736f07f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGx1Z21hbi5qcw==)
| `28.44% <0%> (-0.27%)` | :x: |
    | [cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...ed163b38a8d3235718d6abb254aa9060f736f07f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
| `87.85% <100%> (+0.69%)` | :white_check_mark: |
    | [cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...ed163b38a8d3235718d6abb254aa9060f736f07f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
| `93.79% <0%> (-0.39%)` | :x: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/527?src=pr&el=footer).
Last update [07001dc...a725a79](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...a725a79ca79c83561055a535bcdd7c848e69d01d?el=footer&src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Plugin dependency version/spec is not used/ignored
> --------------------------------------------------
>
>                 Key: CB-10438
>                 URL: https://issues.apache.org/jira/browse/CB-10438
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.0.0, 5.4.1
>            Reporter: Steve Gill
>            Assignee: Steve Gill
>              Labels: as-designed, cordova-7.0.0, triaged
>
> Quite the bug! 
> {code:javascript}
> <dependency id="cordova-plugin-file" spec="3.0.0" />
> or
> <dependency id="cordova-plugin-file" version="3.0.0" />
> {code}
> The above line will ignore spec or version and will always grab the latest. I went back
and tried the previous version of cordova and this seems to be ignoring it as well. Seems
like this was never working.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message