cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8635) InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
Date Fri, 03 Mar 2017 00:43:45 GMT

    [ https://issues.apache.org/jira/browse/CB-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893414#comment-15893414
] 

ASF subversion and git services commented on CB-8635:
-----------------------------------------------------

Commit 461d9e9c4c14479af97e33f925388b1fc20eb838 in cordova-plugin-inappbrowser's branch refs/heads/old-ID
from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=461d9e9 ]

CB-8635 Improves UX on windows platform

* Adds `fullscreen` option
* Adds ability to apply custom styles to IAB window


> InAppBrowser on Windows adds 40px gray border, wrapper div without class or id
> ------------------------------------------------------------------------------
>
>                 Key: CB-8635
>                 URL: https://issues.apache.org/jira/browse/CB-8635
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>    Affects Versions: 3.6.0
>         Environment: Windows 8.1, Windows Phone 8.1
>            Reporter: Brandon Paddock
>
> The InAppBrowserProxy on Windows 8.1 does some weird things. One of them is that it adds
a wrapper div with a bunch of inline styles on it, including a gray 40px border on all sides.
This appears even if you set the "location=no" option to disable the default browser controls.
> Because this div is inserted directly under the body element with no id or class, you
can't override its styling via CSS (and since it uses inline styles, you'd have to use !important
to override them).
> Suggested fixes:
> 1) Assign a class name to the div so it can be styled.
> 2) Don't use an inline style for the default styling. Use CSS.
> 3) Don't put this weird gray border in the default styling (it isn't there on Android
so why put it there on Windows?)
> 4) Or, remove the div entirely (at least in the location=no case).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message