Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 8 Feb 2017 07:57:41 +0000 (UTC)
From: =?utf-8?Q?Jan_Dole=C5=BEel_=28JIRA=29?= <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13040946.1486466926000.25926.1486540661686@Atlassian.JIRA>
In-Reply-To: <JIRA.13040946.1486466926000@Atlassian.JIRA>
References: <JIRA.13040946.1486466926000@Atlassian.JIRA> <JIRA.13040946.1486466926681@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-12433) Make FileError extends native Error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 08 Feb 2017 07:57:49 -0000


    [ https://issues.apache.org/jira/browse/CB-12433?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D158575=
96#comment-15857596 ]=20

Jan Dole=C5=BEel commented on CB-12433:
----------------------------------

Hi, yes I looked at StackOverflow. It's a combination of http://stackoverfl=
ow.com/questions/31089801/extending-error-in-javascript-with-es6-syntax and=
 http://stackoverflow.com/questions/1382107/whats-a-good-way-to-extend-erro=
r-in-javascript
Not sure what is the best way...

And why do it? - https://github.com/petkaantonov/bluebird/blob/master/docs/=
docs/warning-explanations.md#warning-a-promise-was-rejected-with-a-non-erro=
r

And when I look at it now more thoroughly - http://bluebirdjs.com/docs/api/=
catch.html , https://developer.mozilla.org/en-US/docs/Web/JavaScript/Refere=
nce/Global_Objects/Error#Custom_Error_Types

Maybe the best way how to implement it would be:

{code}
function FileError(error) {
  this.code =3D error || null;
  this.message =3D error || null;

  this.name =3D this.constructor.name;
  if (typeof Error.captureStackTrace =3D=3D=3D 'function') {
    Error.captureStackTrace(this, this.constructor);
  } else {
    this.stack =3D (new Error(error)).stack;
  }
 }

FileError.prototype =3D Object.create(Error.prototype);
FileError.prototype.constructor =3D FileError;
{code}

And in future get rid of  `error` property, as according to docs, error sho=
uld use `message`...
Thanks for kicking me to do more deep research :)

> Make FileError extends native Error
> -----------------------------------
>
>                 Key: CB-12433
>                 URL: https://issues.apache.org/jira/browse/CB-12433
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin File
>            Reporter: Jan Dole=C5=BEel
>            Priority: Minor
>
> {code}
> diff --git a/www/FileError.js b/www/FileError.js
> index 6507921..eb681d6 100644
> --- a/www/FileError.js
> +++ b/www/FileError.js
> @@ -24,8 +24,17 @@
>   */
>  function FileError(error) {
>    this.code =3D error || null;
> +
> +  this.name =3D this.constructor.name;
> +  if (typeof Error.captureStackTrace =3D=3D=3D 'function') {
> +    Error.captureStackTrace(this, this.constructor);
> +  } else {
> +    this.stack =3D (new Error(error)).stack;
> +  }
>  }
> +FileError.prototype =3D new Error();
> +
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org