Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 720DE200C2D for ; Sat, 18 Feb 2017 01:23:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 70980160B73; Sat, 18 Feb 2017 00:23:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF867160B6D for ; Sat, 18 Feb 2017 01:23:49 +0100 (CET) Received: (qmail 67326 invoked by uid 500); 18 Feb 2017 00:23:49 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 67224 invoked by uid 99); 18 Feb 2017 00:23:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Feb 2017 00:23:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 86746C023B for ; Sat, 18 Feb 2017 00:23:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id hz7foFestiuB for ; Sat, 18 Feb 2017 00:23:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3B1C05F36C for ; Sat, 18 Feb 2017 00:23:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6EF7DE039E for ; Sat, 18 Feb 2017 00:23:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2B69224121 for ; Sat, 18 Feb 2017 00:23:44 +0000 (UTC) Date: Sat, 18 Feb 2017 00:23:44 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12021) --fetch should use dependency version saved in package.json before default cordova version when adding/restoring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 18 Feb 2017 00:23:50 -0000 [ https://issues.apache.org/jira/browse/CB-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872789#comment-15872789 ] ASF GitHub Bot commented on CB-12021: ------------------------------------- Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/518#discussion_r101873081 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -353,4 +353,5 @@ describe('plugin add and rm end-to-end --fetch', function () { }) .fin(done); }, 60000); -}); \ No newline at end of file +}); + --- End diff -- nit: delete extra new line > --fetch should use dependency version saved in package.json before default cordova version when adding/restoring > ---------------------------------------------------------------------------------------------------------------- > > Key: CB-12021 > URL: https://issues.apache.org/jira/browse/CB-12021 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch, CordovaLib > Reporter: Steve Gill > Assignee: Audrey So > Labels: cordova-7.0.0 > Fix For: 7.0.0 > > > cordova platform add android --save --fetch should use the version of cordova-android already saved in package.json instead of the version from platformsConfig.json -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org