Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 7 Feb 2017 12:16:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12914106.1447852323000.15838.1486469802199@Atlassian.JIRA>
In-Reply-To: <JIRA.12914106.1447852323000@Atlassian.JIRA>
References: <JIRA.12914106.1447852323000@Atlassian.JIRA> <JIRA.12914106.1447852323867@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CB-10033) new resizable cropping rectangle
 instead of Apple's standard square
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 07 Feb 2017 12:16:49 -0000


    [ https://issues.apache.org/jira/browse/CB-10033?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D158558=
64#comment-15855864 ]=20

ASF GitHub Bot commented on CB-10033:
-------------------------------------

Github user cordova-qa commented on the issue:

    https://github.com/apache/cordova-plugin-camera/pull/131
 =20
    Cordova CI Build has one or more failures.=20
   =20
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-camera=
/pull/131/commits/24dce90b10bac051be399abe40173029587ba55e)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-=
plugin-camera-pr/131/)
   =20
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-=
plugin-camera-pr/131//PLATFORM=3Dwindows-10-store/) | [Link]( http://cordov=
a-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/131//PLATFORM=3Dwindows=
-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordov=
a-plugin-camera-pr/131//PLATFORM=3Dwindows-10-store/testReport/) | [Link]( =
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/131//PLATF=
ORM=3Dwindows-10-store/artifact/) |
    | [iOS 9.3]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-cam=
era-pr/131//PLATFORM=3Dios-9.3/) | [Link]( http://cordova-ci.cloudapp.net:8=
080/job/cordova-plugin-camera-pr/131//PLATFORM=3Dios-9.3/console) | [Link](=
 http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/131//PLAT=
FORM=3Dios-9.3/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/j=
ob/cordova-plugin-camera-pr/131//PLATFORM=3Dios-9.3/artifact/) |
    | [iOS 10.0]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-ca=
mera-pr/131//PLATFORM=3Dios-10.0/) | [Link]( http://cordova-ci.cloudapp.net=
:8080/job/cordova-plugin-camera-pr/131//PLATFORM=3Dios-10.0/console) | [Lin=
k]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/131//P=
LATFORM=3Dios-10.0/testReport/) | [Link]( http://cordova-ci.cloudapp.net:80=
80/job/cordova-plugin-camera-pr/131//PLATFORM=3Dios-10.0/artifact/) |
    | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-cam=
era-pr/131//PLATFORM=3Dandroid/) | [Link]( http://cordova-ci.cloudapp.net:8=
080/job/cordova-plugin-camera-pr/131//PLATFORM=3Dandroid/console) | [Link](=
 http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/131//PLAT=
FORM=3Dandroid/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/j=
ob/cordova-plugin-camera-pr/131//PLATFORM=3Dandroid/artifact/) |
    =20


> new resizable cropping rectangle instead of Apple's standard square
> -------------------------------------------------------------------
>
>                 Key: CB-10033
>                 URL: https://issues.apache.org/jira/browse/CB-10033
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin Camera
>         Environment: iOS
>            Reporter: Manfred W=C3=BChr
>            Priority: Minor
>              Labels: feature, iOS
>
> On iOS there's only that very insufficient inflexible cropping square =E2=
=80=93 compared to Android or WinMobile =E2=80=93 which moreover obviously =
doesn=E2=80=99t work properly (see CB-9930, CB-2648).
> As we need a flexible, sizable rectangle, we implemented that in our fork=
 of the camera plugin.
> And with that we even already submitted a [pull request|https://github.co=
m/apache/cordova-plugin-camera/pull/131].
> (being very new to Cordova we didn=E2=80=99t realize, that there obviousl=
y has to be such a JIRA issue, before).
> To be downward compatible and to not urge others, for whom that square ma=
y be sufficient, it is made parametrizable via a new preference (as this is=
 iOS specific and nothing that has to be changeable at runtime), defaulting=
 to false.
> If the plugin is called with option allowEdit =3D=3D true, then setting t=
his new preference to true suppresses that standard (fairly useless) square=
 for cropping the photo, even suppresses the (then also useless) view of th=
e photo with the "Retake"- and "Use Photo"-buttons, but instead offers a re=
sizable cropping rectangle (with "Redo" and "Save=E2=80=9C).
> More detail about how it=E2=80=99s implemented can be found in the commen=
t of the mentioned pull request;
> and as there already started a discussion, I added more detail and though=
ts [here|https://github.com/apache/cordova-plugin-camera/pull/131#issuecomm=
ent-156117731] and [here|https://github.com/apache/cordova-plugin-camera/pu=
ll/131#issuecomment-156988289].
> We think others could use and want that, too =E2=80=93 in the standard pl=
ug in.
> Yes, it is platform specific, but on Android and WinMobile it=E2=80=99s a=
lready possible to crop with a flexible rectangle (somehow =E2=80=93 knowin=
g, that Android also isn=E2=80=99t really satisfying).
> I also emailed dev@cordova.apache.org with a [proposal|http://callback.ma=
rkmail.org/thread/5bjkv4ukymo6ybot].


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org