cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-12497) location.href links are silently disallowed
Date Sun, 26 Feb 2017 00:19:44 GMT


ASF GitHub Bot commented on CB-12497:

Github user asfgit closed the pull request at:

> location.href links are silently disallowed
> -------------------------------------------
>                 Key: CB-12497
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
> See:
> Ok, for location.href (say in a button tag onclick handler), it's definitely a bug when
using wkwebview-engine (UIWebView is fine). For the CDVIntentAndNavigationFilter, we are passing
back the navigationType, which is of type [WKNavigationType](
It looks like the enumeration is the same as [UIWebViewNavigationType](
(which the filter uses for its logic), but not quite. 
> All enum integral values are the same for the two enumerations, except for [WKNavigationTypeOther](
which is set to -1 explicitly, while [UIWebViewNavigationTypeOther](
is 5.
> I'll file an issue to fix this by coercing the value explicitly to UIWebViewNavigationTypeOther
when a WKNavigationTypeOther is encountered, before passing it off to the filter.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message