cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12424) Multipart messages are broken
Date Mon, 13 Feb 2017 01:03:41 GMT

    [ https://issues.apache.org/jira/browse/CB-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863092#comment-15863092
] 

ASF GitHub Bot commented on CB-12424:
-------------------------------------

Github user shankari commented on the issue:

    https://github.com/apache/cordova-android/pull/358
  
    Note that the multi-part handling appears to be a regression.
    When I was on android@5.1.1, the email composer plugin, which returns a multi-part result
from `isAvailable` worked. When I upgraded to android@6.1.2, it stopped working.
    https://github.com/shankari/cordova-plugin-email-composer/blob/master/src/android/EmailComposer.java#L112
    
    ```
                    List<PluginResult> messages = new ArrayList<PluginResult>();
    
                    messages.add(new PluginResult(PluginResult.Status.OK, available[0]));
                    messages.add(new PluginResult(PluginResult.Status.OK, available[1]));
    
                    PluginResult result = new PluginResult(
                            PluginResult.Status.OK, messages);
    ```
    
    Note further that multipart messages seem to be handled just fine in `encodeAsMessageHelper`
(and, by implication, in `encodeAsMessage`) but not in `encodeAsJsMessage`. Is this due to
the switch in the default bridge?


> Multipart messages are broken
> -----------------------------
>
>                 Key: CB-12424
>                 URL: https://issues.apache.org/jira/browse/CB-12424
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0, 6.2.0
>         Environment: cordova 6.4.0
> android 6.0.0 / git master
> Mac El Capitan
>            Reporter: Joshua Jackson
>            Priority: Minor
>             Fix For: 6.2.0
>
>
> Currently when I try to assemble a multipart message cordova-android assembles the data
in NativeToJsMessageQueue.java as [""] but if I call pMessageLoopResponse(callbackContext,
3, 5) it should generate [3, 5]
>     private void pMessageLoopResponse(final CallbackContext ctx, int iMsg, int iTag)
{
>         List<PluginResult> results = new ArrayList<PluginResult>();
>         results.add(0, new PluginResult(PluginResult.Status.OK, iMsg));
>         results.add(1, new PluginResult(PluginResult.Status.OK, iTag));
>         PluginResult result = new PluginResult(PluginResult.Status.OK, results);
>         result.setKeepCallback(true);
>         ctx.sendPluginResult(result);
>     }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message