cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12424) Multipart messages are broken
Date Fri, 03 Feb 2017 21:53:52 GMT

    [ https://issues.apache.org/jira/browse/CB-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852181#comment-15852181
] 

ASF GitHub Bot commented on CB-12424:
-------------------------------------

GitHub user kalliste opened a pull request:

    https://github.com/apache/cordova-android/pull/358

    CB-12424: (android) Fix encoding of multipart messages.

    
    Currently when I try to assemble a multipart message cordova-android assembles the data
in NativeToJsMessageQueue.java as [""] but if I call pMessageLoopResponse(callbackContext,
3, 5) it should generate [3, 5]
    
        private void pMessageLoopResponse(final CallbackContext ctx, int iMsg, int iTag) {
            List<PluginResult> results = new ArrayList<PluginResult>();
            results.add(0, new PluginResult(PluginResult.Status.OK, iMsg));
            results.add(1, new PluginResult(PluginResult.Status.OK, iTag));
            PluginResult result = new PluginResult(PluginResult.Status.OK, results);
            result.setKeepCallback(true);
            ctx.sendPluginResult(result);
        }
    
    We split off encodeMessageAsJsMessage as its own method to support multipart messages
including ones containing array buffer, binary string, or other multipart messages.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kalliste/cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #358
    
----
commit 2dd9acf2fa0c179269002e369cb0d7df598741eb
Author: Josh Jackson <jjackson@kallisteconsulting.com>
Date:   2017-02-03T21:20:37Z

    Fix encoding of multipart messages.

----


> Multipart messages are broken
> -----------------------------
>
>                 Key: CB-12424
>                 URL: https://issues.apache.org/jira/browse/CB-12424
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0, 6.2.0
>         Environment: cordova 6.4.0
> android 6.0.0 / git master
> Mac El Capitan
>            Reporter: Joshua Jackson
>            Priority: Minor
>             Fix For: 6.2.0
>
>
> Currently when I try to assemble a multipart message cordova-android assembles the data
in NativeToJsMessageQueue.java as [""] but if I call pMessageLoopResponse(callbackContext,
3, 5) it should generate [3, 5]
>     private void pMessageLoopResponse(final CallbackContext ctx, int iMsg, int iTag)
{
>         List<PluginResult> results = new ArrayList<PluginResult>();
>         results.add(0, new PluginResult(PluginResult.Status.OK, iMsg));
>         results.add(1, new PluginResult(PluginResult.Status.OK, iTag));
>         PluginResult result = new PluginResult(PluginResult.Status.OK, results);
>         result.setKeepCallback(true);
>         ctx.sendPluginResult(result);
>     }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message