cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12424) Multipart messages are broken
Date Fri, 17 Feb 2017 15:31:41 GMT

    [ https://issues.apache.org/jira/browse/CB-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871987#comment-15871987
] 

ASF GitHub Bot commented on CB-12424:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-android/pull/358
  
    # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/358?src=pr&el=h1) Report
    > Merging [#358](https://codecov.io/gh/apache/cordova-android/pull/358?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-android/commit/5591a1a4e896ed8693abd5234cb2370ead20ed5d?src=pr&el=desc)
will **not change** coverage.
    > The diff coverage is `n/a`.
    
    
    ```diff
    @@           Coverage Diff           @@
    ##           master     #358   +/-   ##
    =======================================
      Coverage   35.58%   35.58%           
    =======================================
      Files          12       12           
      Lines        1037     1037           
      Branches      173      173           
    =======================================
      Hits          369      369           
      Misses        668      668
    ```
    
    
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/358?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/358?src=pr&el=footer).
Last update [5591a1a...3e03f0d](https://codecov.io/gh/apache/cordova-android/compare/5591a1a4e896ed8693abd5234cb2370ead20ed5d...3e03f0da51c4c39a20867c804c5c7b7b4ca44a30?el=footer&src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Multipart messages are broken
> -----------------------------
>
>                 Key: CB-12424
>                 URL: https://issues.apache.org/jira/browse/CB-12424
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0, 6.2.0
>         Environment: cordova 6.4.0
> android 6.0.0 / git master
> Mac El Capitan
>            Reporter: Joshua Jackson
>            Priority: Minor
>             Fix For: 6.2.0
>
>
> Currently when I try to assemble a multipart message cordova-android assembles the data
in NativeToJsMessageQueue.java as [""] but if I call pMessageLoopResponse(callbackContext,
3, 5) it should generate [3, 5]
>     private void pMessageLoopResponse(final CallbackContext ctx, int iMsg, int iTag)
{
>         List<PluginResult> results = new ArrayList<PluginResult>();
>         results.add(0, new PluginResult(PluginResult.Status.OK, iMsg));
>         results.add(1, new PluginResult(PluginResult.Status.OK, iTag));
>         PluginResult result = new PluginResult(PluginResult.Status.OK, results);
>         result.setKeepCallback(true);
>         ctx.sendPluginResult(result);
>     }



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message