cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12416) (Windows) Built bundles are misplaced when building for multiple archs
Date Fri, 03 Feb 2017 13:40:51 GMT

    [ https://issues.apache.org/jira/browse/CB-12416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851494#comment-15851494
] 

ASF GitHub Bot commented on CB-12416:
-------------------------------------

GitHub user daserge reopened a pull request:

    https://github.com/apache/cordova-windows/pull/226

    CB-12416 (Windows) Built bundles are misplaced when building for mult…

    …iple archs
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Override default MSBuild behavior which is to use `AppxBundle=Always` for Windows 10 builds
    
    ### What testing has been done on this change?
    Run npm test, manually checked AppPackages folder output for --bundle and default (non-bundled)
cases.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-12416

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
    
----
commit 8f086e2f0b2ffe75bae70f7eb22911310bf71e0f
Author: daserge <v-seshak@microsoft.com>
Date:   2017-02-02T10:58:32Z

    CB-12416 (Windows) Built bundles are misplaced when building for multiple archs

----


> (Windows) Built bundles are misplaced when building for multiple archs
> ----------------------------------------------------------------------
>
>                 Key: CB-12416
>                 URL: https://issues.apache.org/jira/browse/CB-12416
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: Master
>            Reporter: Alexander Sorokin
>              Labels: triaged
>
> When running a command like {{cordova build windows --release -- --archs="arm x86 x64"}},
the expected output would be that each built bundle is located in its own folder, like this:
> {{CordovaApp.Windows10_1.0.0.0_arm_Test}}
> {{CordovaApp.Windows10_1.0.0.0_x86_Test}}
> {{CordovaApp.Windows10_1.0.0.0_x64_Test}}
> But cordova-windows@5.0.0 builds only the first specified architecture in its own folder,
like this:
> {{CordovaApp.Windows10_1.0.0.0_arm_Test}} <- arm package here
> {{CordovaApp.Windows10_1.0.0.0_Test}} <- x86 and x64 packages here



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message