cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jess Holle (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12283) EVAL_BRIDGE does not support multipart PluginResults
Date Tue, 14 Feb 2017 23:04:41 GMT

    [ https://issues.apache.org/jira/browse/CB-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866891#comment-15866891
] 

Jess Holle commented on CB-12283:
---------------------------------

How can a regression that breaks any existing plugin that uses multipart PluginResults have
a "minor" priority?

> EVAL_BRIDGE does not support multipart PluginResults
> ----------------------------------------------------
>
>                 Key: CB-12283
>                 URL: https://issues.apache.org/jira/browse/CB-12283
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0
>            Reporter: Jess Holle
>            Assignee: Joe Bowser
>
> When moving from Cordova 5.1.1 to 6.0.0 our multi-part PluginResult communication started
failing (without any other changes to the application).  This issue goes away if we force
use of ONLINE_EVENT rather than EVAL_BRDIGE mode.
> Further investigation shows that with EVAL_BRIDGE multi-part PluginResults result in
[""] being sent as the response data, e.g.:
> cordova.callbackFromNative('Vuforia296582484',true,1,[""],true);
> This is clearly wrong and a result of JsMessage.encodeAsJsMessage(StringBuilder) having
no case for MESSAGE_TYPE_MULTIPART (nor any appropriate delegate to ensure proper handling).
 Reviewing the 6.1.0 sources suggests this has still not been fixed there.
> Given the switch of the default bridge mode on Android to EVAL_BRIDGE, this is a very
serious regression and breakage of existing plugins.  This should either be fixed or the bridge
mode reverted to ONLINE_EVENT once again.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message