cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12105) window.device.model returns "Chrome" instead of "Edge" when using MS Edge
Date Tue, 28 Feb 2017 08:13:45 GMT

    [ https://issues.apache.org/jira/browse/CB-12105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887509#comment-15887509
] 

ASF GitHub Bot commented on CB-12105:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-device/pull/61

    CB-12105 (browser) Properly detect Edge

    ### Platforms affected
    Browser
    
    ### What does this PR do?
    Allows the plugin to properly detect Edge browser.
    https://issues.apache.org/jira/browse/CB-12105
    
    ### What testing has been done on this change?
    Tested on Edge 38, Chrome 56, Firefox 51
    
    ### Checklist
    - [x] [Reported an issue](https://issues.apache.org/jira/browse/CB-12105) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-device CB-12105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 4472603a42859084f1a151ebc3676421d33547a7
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2017-02-28T08:09:13Z

    CB-12105 (browser) Properly detect Edge

----


> window.device.model returns "Chrome" instead of "Edge" when using MS Edge
> -------------------------------------------------------------------------
>
>                 Key: CB-12105
>                 URL: https://issues.apache.org/jira/browse/CB-12105
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Device
>    Affects Versions: 6.3.2
>            Reporter: Mark Veenstra
>            Assignee: Alexander Sorokin
>            Priority: Critical
>
> When building for platform browser the {{cordova-plugin-device}} (v1.3.2) returns "Chrome"
instead of "Edge" when requesting {{window.device.model}} on an Edge browser.
> In the {{DeviceProxy.js}} the following code is there: https://github.com/apache/cordova-plugin-device/blob/master/src/browser/DeviceProxy.js#L40
> {code}
> function getBrowserInfo(getModel) {
>     var userAgent = navigator.userAgent;
>     var returnVal = '';
>     var offset;
>     if ((offset = userAgent.indexOf('Chrome')) !== -1) {
>         returnVal = (getModel) ? 'Chrome' : userAgent.substring(offset + 7);
>     } else if ((offset = userAgent.indexOf('Safari')) !== -1) {
>         if (getModel) {
>             returnVal = 'Safari';
>         } else {
>             returnVal = userAgent.substring(offset + 7);
>             if ((offset = userAgent.indexOf('Version')) !== -1) {
>                 returnVal = userAgent.substring(offset + 8);
>             }
>         }
>     } else if ((offset = userAgent.indexOf('Firefox')) !== -1) {
>         returnVal = (getModel) ? 'Firefox' : userAgent.substring(offset + 8);
>     } else if ((offset = userAgent.indexOf('MSIE')) !== -1) {
>         returnVal = (getModel) ? 'MSIE' : userAgent.substring(offset + 5);
>     } else if ((offset = userAgent.indexOf('Trident')) !== -1) {
>         returnVal = (getModel) ? 'MSIE' : '11';
>     }
>     if ((offset = returnVal.indexOf(';')) !== -1 || (offset = returnVal.indexOf(' '))
!== -1) {
>         returnVal = returnVal.substring(0, offset);
>     }
>     return returnVal;
> }
> {code}
> The code above returns model Chrome as soon as it is in the userAgent string. MS Edge
provides the following userAgent string: {{Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393}}
> So it seems we should be checking first if "Edge" is part of the userAgent. If so the
browser would be Edge.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message