cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12021) --fetch should use dependency version saved in package.json before default cordova version when adding/restoring
Date Sat, 18 Feb 2017 00:23:44 GMT

    [ https://issues.apache.org/jira/browse/CB-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872791#comment-15872791
] 

ASF GitHub Bot commented on CB-12021:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/518#discussion_r101873667
  
    --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
    @@ -742,7 +742,7 @@ describe('update config.xml to use the variable found in pkg.json',
function ()
             process.chdir(path.join(__dirname, '..'));  // Needed to rm the dir on Windows.
             shell.rm('-rf', tmpDir);
         });
    -
    +    
    --- End diff --
    
    nit: unnecessary tab


> --fetch should use dependency version saved in package.json before default cordova version
when adding/restoring
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-12021
>                 URL: https://issues.apache.org/jira/browse/CB-12021
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-fetch, CordovaLib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> cordova platform add android --save --fetch should use the version of cordova-android
already saved in package.json instead of the version from platformsConfig.json



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message