cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12021) --fetch should use dependency version saved in package.json before default cordova version when adding/restoring
Date Fri, 17 Feb 2017 16:12:41 GMT

    [ https://issues.apache.org/jira/browse/CB-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872036#comment-15872036
] 

ASF GitHub Bot commented on CB-12021:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/518
  
    # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/518?src=pr&el=h1) Report
    > Merging [#518](https://codecov.io/gh/apache/cordova-lib/pull/518?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-lib/commit/a9605411ab007d700849c971043f0c211c06100c?src=pr&el=desc)
will **increase** coverage by `0.17%`.
    > The diff coverage is `n/a`.
    
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #518      +/-   ##
    ==========================================
    + Coverage    81.8%   81.98%   +0.17%     
    ==========================================
      Files          68       68              
      Lines        5459     5500      +41     
      Branches     1072     1086      +14     
    ==========================================
    + Hits         4466     4509      +43     
    + Misses        993      991       -2
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/518?src=pr&el=tree)
| Coverage Δ | |
    |---|---|---|
    | [cordova-lib/src/cordova/plugin.js](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...c8bf8028efa84287c9876d44a94255233b9e0974?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGx1Z2luLmpz)
| `89.75% <ø> (-0.09%)` | :x: |
    | [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...c8bf8028efa84287c9876d44a94255233b9e0974?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
| `78.34% <ø> (+1.08%)` | :white_check_mark: |
    | [cordova-lib/src/plugman/fetch.js](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...c8bf8028efa84287c9876d44a94255233b9e0974?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vZmV0Y2guanM=)
| `81.46% <ø> (+2.04%)` | :white_check_mark: |
    | [cordova-lib/src/cordova/platform_metadata.js](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...c8bf8028efa84287c9876d44a94255233b9e0974?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm1fbWV0YWRhdGEuanM=)
| `88.88% <ø> (+2.22%)` | :white_check_mark: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/518?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/518?src=pr&el=footer).
Last update [a960541...f8b4483](https://codecov.io/gh/apache/cordova-lib/compare/a9605411ab007d700849c971043f0c211c06100c...f8b4483150c3c42029547b583117042295a4113d?src=pr&el=footer&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> --fetch should use dependency version saved in package.json before default cordova version
when adding/restoring
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-12021
>                 URL: https://issues.apache.org/jira/browse/CB-12021
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-fetch, CordovaLib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> cordova platform add android --save --fetch should use the version of cordova-android
already saved in package.json instead of the version from platformsConfig.json



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message