cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12021) --fetch should use dependency version saved in package.json before default cordova version when adding/restoring
Date Fri, 17 Feb 2017 00:29:42 GMT

    [ https://issues.apache.org/jira/browse/CB-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870939#comment-15870939
] 

ASF GitHub Bot commented on CB-12021:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/518

    CB-12021 : --fetch should use dependency version saved in package.json before default
cordova version when adding/restoring

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
     --fetch should use dependency version saved in package.json before default cordova version
when adding/restoring
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib fixfetch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #518
    
----
commit f448f2f6530222ff39f5b1658f9fede50df0720b
Author: audreyso <auso@adobe.com>
Date:   2016-10-07T21:19:06Z

    CB-11960: Added support to package.json for platform/plugin add/rm

commit b3ca300172fdb94860a523505ab12d90512d984c
Author: Steve Gill <stevengill97@gmail.com>
Date:   2016-11-04T20:55:52Z

     CB-12021: Added local path support to --fetch and fixed failing tests for adding a relative
path

commit e5efb1a92a10f3e179618354373b0a51975f6588
Author: Audrey So <audreyso@apache.org>
Date:   2017-02-15T18:10:32Z

    fixfetch : updated index.js to deal with local path

commit a5b0441d5572a9c37b235e33bd6d7af3ce9ffc03
Author: Audrey So <audreyso@apache.org>
Date:   2017-02-16T02:03:25Z

    CB-12021 : updated platform.js to fix failing tests and modified test 25 to check for
config.xml too

commit 4d095776ce058dc52f74ef56912ff3cae6b28a49
Author: Audrey So <audreyso@apache.org>
Date:   2017-02-16T23:40:53Z

    CB-12021 : updated jshint and added includes method to support node 0.x

commit c8bf8028efa84287c9876d44a94255233b9e0974
Author: Audrey So <audreyso@apache.org>
Date:   2017-02-17T00:23:40Z

    CB-12021 : adding cordova-browser node_modules

----


> --fetch should use dependency version saved in package.json before default cordova version
when adding/restoring
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-12021
>                 URL: https://issues.apache.org/jira/browse/CB-12021
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-fetch, CordovaLib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> cordova platform add android --save --fetch should use the version of cordova-android
already saved in package.json instead of the version from platformsConfig.json



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message