cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12016) remove plugin ID mapping
Date Tue, 28 Feb 2017 19:12:45 GMT

    [ https://issues.apache.org/jira/browse/CB-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888695#comment-15888695
] 

ASF GitHub Bot commented on CB-12016:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/522#discussion_r103528081
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -257,7 +237,7 @@ function checkID(expectedIdAndVersion, pinfo) {
         var parsedSpec = pluginSpec.parse(expectedIdAndVersion);
     
         if (parsedSpec.id != pinfo.id) {
    -        var alias = parsedSpec.scope ? null : pluginMappernto[parsedSpec.id] || pluginMapperotn[parsedSpec.id];
    +        var alias = null;
             if (alias !== pinfo.id) {
    --- End diff --
    
    LGTM


> remove plugin ID mapping
> ------------------------
>
>                 Key: CB-12016
>                 URL: https://issues.apache.org/jira/browse/CB-12016
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, CordovaLib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> For cordova@7, we can remove the cordova-registry-mapper module and remove the automatic
plugin mapping we do



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message