cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11346) Remove known platforms check for Platform API
Date Tue, 21 Feb 2017 01:49:44 GMT

    [ https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875220#comment-15875220
] 

ASF GitHub Bot commented on CB-11346:
-------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-lib/pull/519

    CB-11346 - Remove known platforms check for Platform API

    ### Platforms affected
    
    CLI
    
    ### What does this PR do?
    
    Removes platforms check. Right now only known platforms are installable.
    
    ### What testing has been done on this change?
    
    None. Unit tests are coming.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-lib CB-11346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #519
    
----
commit 3effebb17fc3209ab78a503bf0ca793d7a853af6
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-02-21T01:47:14Z

    CB-11346 - Remove known platforms check for Platform API

----


> Remove known platforms check for Platform API
> ---------------------------------------------
>
>                 Key: CB-11346
>                 URL: https://issues.apache.org/jira/browse/CB-11346
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Shazron Abdullah
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message