Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 5 Jan 2017 18:58:59 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13032338.1483641748000.653078.1483642739056@Atlassian.JIRA>
In-Reply-To: <JIRA.13032338.1483641748000@Atlassian.JIRA>
References: <JIRA.13032338.1483641748000@Atlassian.JIRA> <JIRA.13032338.1483641748748@arcas>
Subject: [jira] [Commented] (CB-12320) Support using navigation bar in iOS
 instead of toolbar
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 05 Jan 2017 18:59:00 -0000


    [ https://issues.apache.org/jira/browse/CB-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802197#comment-15802197 ] 

ASF GitHub Bot commented on CB-12320:
-------------------------------------

GitHub user spongessuck opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/206

    CB-12320: (iOS) WIP Add support for navigation bar 

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    - Adds support for using the iOS navigation bar as an alternative to a top-positioned toolbar. This makes the toolbar look much more native. When `navigationbar=yes` is set, it puts the toolbar buttons in the navigation bar and hides the toolbar.
    - Allows for the navigation buttons to be hidden using `navigationbuttons=no`.
    - Allows for adding a title to the navigation bar using `navigationbartitle`.
    
    ### What testing has been done on this change?
    Tested to make sure the new options are respected. I'm not sure what kind of automated tests might be required/have to be changed.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    ### Issues
    - Location bar doesn't appear correctly when `toolbarposition=top` is set.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spongessuck/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #206
    
----
commit 429402406298d772e01e9e959cbcb2d9d0b21fbf
Author: Gregory McGee <spongessuck@gmail.com>
Date:   2017-01-05T18:52:12Z

    CB-12320: (iOS) Add support for navigation bar

----


> Support using navigation bar in iOS instead of toolbar
> ------------------------------------------------------
>
>                 Key: CB-12320
>                 URL: https://issues.apache.org/jira/browse/CB-12320
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: Plugin InAppBrowser
>         Environment: iOS
>            Reporter: Greg McGee
>            Priority: Minor
>              Labels: ui
>
> This would allow the 'toolbar' to have a more native look in iOS when it's positioned on top. It would also avoid having to add padding and an extra view on the top of the toolbar to make room for the status bar, which looks strange when using 'presentationstyle=pagesheet', and it would allow for easily adding a title.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org