Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 5 Jan 2017 07:09:58 +0000 (UTC)
From: "Sasa Bojanic (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.13030124.1482416451000.647437.1483600198348@Atlassian.JIRA>
In-Reply-To: <JIRA.13030124.1482416451000@Atlassian.JIRA>
References: <JIRA.13030124.1482416451000@Atlassian.JIRA> <JIRA.13030124.1482416451807@arcas>
Subject: [jira] [Commented] (CB-12293) The addPlugin function in Api.js
 assumes Gradle is used for build (patch introduced for Gradle in
 cordova-android version 6.0.0)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 05 Jan 2017 07:10:00 -0000


    [ https://issues.apache.org/jira/browse/CB-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800578#comment-15800578 ] 

Sasa Bojanic commented on CB-12293:
-----------------------------------

Well, not sure if it would break the build if there is no internet on the machine we are building, but it breaks our concept for sure.
It starts to download gradle and other unnecessary things from the internet.

It is a bad news for us to hear that ANT will not be supported in the future versions...

> The addPlugin function in Api.js assumes Gradle is used for build (patch introduced for Gradle in cordova-android version 6.0.0)
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-12293
>                 URL: https://issues.apache.org/jira/browse/CB-12293
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.0.0
>            Reporter: Sasa Bojanic
>            Assignee: Joe Bowser
>
> The patch for Gradle in Api.js, addPlugin function assumes that Gradle is used for build.
> However, I'm using ant, in which case it unnecessarily downloads Gradle, etc...
> This issue is introduced in cordova-android version 6.0.0:
> return Q()
>        .then(function () {
>             //CB-11964: Do a clean when installing the plugin code to get around
>             //the Gradle bug introduced by the Android Gradle Plugin Version 2.2
>             //TODO: Delete when the next version of Android Gradle plugin comes out
>            // Since clean doesn't just clean the build, it also wipes out www, we need
>            // to pass additional options.
>            // Do some basic argument parsing
>             var opts = installOptions;//{"options":{"argv":["--ant"]}};
>             // Skip cleaning prepared files when not invoking via cordova CLI.
>             opts.noPrepare = true;
>             return self.clean(opts);
>         })
> ....


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org