Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 294B7200C15 for ; Wed, 4 Jan 2017 00:34:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2836C160B43; Tue, 3 Jan 2017 23:34:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6E340160B46 for ; Wed, 4 Jan 2017 00:33:59 +0100 (CET) Received: (qmail 69036 invoked by uid 500); 3 Jan 2017 23:33:58 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 68999 invoked by uid 99); 3 Jan 2017 23:33:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 23:33:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6920F2C2A6B for ; Tue, 3 Jan 2017 23:33:58 +0000 (UTC) Date: Tue, 3 Jan 2017 23:33:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 03 Jan 2017 23:34:00 -0000 [ https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796553#comment-15796553 ] ASF GitHub Bot commented on CB-11136: ------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 > InAppBrowser fails to close with WKWebView OAuth > ------------------------------------------------- > > Key: CB-11136 > URL: https://issues.apache.org/jira/browse/CB-11136 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin InAppBrowser, Plugin WKWebViewEngine > Affects Versions: 4.1.0 > Environment: iOS 8+ with WKWebView > Reporter: Geordie Jay > Assignee: Shazron Abdullah > Labels: pull-request-available > Original Estimate: 3h > Remaining Estimate: 3h > > Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for OAuth (e.g. Facebook or Google login) fails to close as it should. > The reason is that the entire WKWebView thread seems to pause when another view controller is presented. This can be confirmed by inspecting the WKWebView session in Safari, running `window.open('http://something.com')` and then trying to enter another command into that Safari console. > I made a hacky but working version of this that animated in the InAppBrowser's view manually, rather than 'presenting' the ViewController in the traditional iOS style. In that instance the WKWebView thread continues as normal and receives the confirmation to close the other InAppBrowser when the OAuth process is complete. > Maybe there is a better way around this, but at the moment this is a big usability fail for all WKWebView users. > What do you all think, is the 'not-actually-presenting' way of presenting the InAppBrowser acceptable? Would be happy to make a pull request along these lines if it is. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org